Never. The official launcher never asks for your password in a pop-up window. It uses Microsoft OAuth (a browser window). If a launcher asks for your password directly, it is a phishing scam to steal your Microsoft account.
If you are looking for a launcher that costs nothing to download, here are the best options available today. minecraft java launcher free
After playing the demo for 100 minutes, you will likely be hooked. Here is why paying for the full version is worth the money: minecraft java launcher free